Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing printf family from Ref, Drv, RPI, OS, Utils #3141

Open
wants to merge 7 commits into
base: devel
Choose a base branch
from

Conversation

LeStarch
Copy link
Collaborator

Related Issue(s)
Has Unit Tests (y/n)
Documentation Included (y/n)

Change Description

Partial fix for #1708. This addresses Ref, RPI, Utils, Drv, and Os.

Note: I left printf in RPI/Main.cpp and Ref/Main.cpp as these calls are on Linux and explicitly to inform the user of runtime items on that platform. Thus these were deemed correct usage.

Remaining Work

Svc and Fw.

Fw/Types/StringUtils.cpp Fixed Show fixed Hide fixed
@@ -72,3 +73,10 @@
// if we make it here, no matches were found
return -1;
}

void Fw::StringUtils::format(CHAR* destination, Fw::StringBase::SizeType size, const CHAR* format, ...) {

Check notice

Code scanning / CodeQL

Use of basic integral type Note

destination uses the basic integral type char rather than a typedef with size and signedness.
@@ -72,3 +73,10 @@
// if we make it here, no matches were found
return -1;
}

void Fw::StringUtils::format(CHAR* destination, Fw::StringBase::SizeType size, const CHAR* format, ...) {

Check notice

Code scanning / CodeQL

Use of basic integral type Note

size uses the basic integral type unsigned int rather than a typedef with size and signedness.
@@ -72,3 +73,10 @@
// if we make it here, no matches were found
return -1;
}

void Fw::StringUtils::format(CHAR* destination, Fw::StringBase::SizeType size, const CHAR* format, ...) {

Check notice

Code scanning / CodeQL

Use of basic integral type Note

format uses the basic integral type char rather than a typedef with size and signedness.
Fw/Types/StringUtils.cpp Fixed Show fixed Hide fixed
Fw/Types/StringUtils.cpp Fixed Show fixed Hide fixed
Fw/Types/StringUtils.cpp Fixed Show fixed Hide fixed
@LeStarch LeStarch requested a review from thomas-bc January 22, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants