-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nos3#221 eps battery monitoring #8
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anel power output
…ta to adjust the solar power received, and changing the size of messages to contain battery value data
…oint as the EPS wouldn't know this and would simply communicate this via battery voltage fluxuations;
…tracked with batteries only and simply print out svb_X/Y/Z in update_battery_values;
…ent onwards, but it needs to be in the simulator
… on the charge of the battery, as well as corrections to the numbers to make them at least plausible.
jlucas9
reviewed
Feb 8, 2024
…configuration file
msuder
reviewed
Feb 13, 2024
@Isgaroth-the-Green would you mind revisiting the above and resolving the conversations? |
… fixed value for calculating power draw/generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to track battery power (and update the voltage accordingly)