Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nos3#221 eps battery monitoring #8

Merged
merged 11 commits into from
Feb 16, 2024

Conversation

Isgaroth-the-Green
Copy link
Contributor

Updates to track battery power (and update the voltage accordingly)

Isgaroth-the-Green and others added 8 commits December 14, 2023 13:42
…ta to adjust the solar power received, and changing the size of messages to contain battery value data
…oint as the EPS wouldn't know this and would simply communicate this via battery voltage fluxuations;
…tracked with batteries only and simply print out svb_X/Y/Z in update_battery_values;
…ent onwards, but it needs to be in the simulator
… on the charge of the battery, as well as corrections to the numbers to make them at least plausible.
@jlucas9 jlucas9 requested a review from msuder February 8, 2024 13:33
@jlucas9 jlucas9 changed the base branch from main to dev February 8, 2024 13:36
@jlucas9
Copy link
Member

jlucas9 commented Feb 15, 2024

@Isgaroth-the-Green would you mind revisiting the above and resolving the conversations?

… fixed value for calculating power draw/generation
@Isgaroth-the-Green Isgaroth-the-Green merged commit 2b7db57 into dev Feb 16, 2024
@jlucas9 jlucas9 deleted the nos3#221-eps-battery-monitoring branch February 19, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants