Kstansifer mask index #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harmonbhasin
previously approved these changes
Jan 13, 2025
There was a problem hiding this comment.
@katherine-stansifer this looks great! Going through your doc was super helpful. For future reference, we typically merge into dev and only merge dev into master when there are sufficient changes.
@willbradshaw this is ready for you to look at.
harmonbhasin
previously approved these changes
Jan 13, 2025
There was a problem hiding this comment.
@katherine-stansifer the only thing I think you're missing is updating the CHANGELOG, however this is currently being discussed #138 by Will and Jeff so you can hold off on this.
harmonbhasin
assigned harmonbhasin, katherine-stansifer and willbradshaw and unassigned harmonbhasin and katherine-stansifer
willbradshaw
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds adapter/complexity/polyX masking step to index workflow.
This new mask index should enable switching order of adapter trimming and bbduk viral filtering