Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update run_validation.config (dropping read_type.config) #140

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Update run_validation.config (dropping read_type.config) #140

merged 3 commits into from
Jan 14, 2025

Conversation

simonleandergrimm
Copy link
Collaborator

No description provided.

@simonleandergrimm
Copy link
Collaborator Author

@harmonbhasin please review.

@simonleandergrimm simonleandergrimm mentioned this pull request Jan 10, 2025
Merged
harmonbhasin
harmonbhasin previously approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@harmonbhasin harmonbhasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I just checked the master branch and this is implemented there so we may consider pushing this to master sooner then our next update, as run_validation.config is currently unfunctional in the master branch. @willbradshaw thoughts?

@willbradshaw
Copy link
Contributor

@simonleandergrimm please add a CHANGELOG edit and then PR to master and I'll merge.

@simonleandergrimm
Copy link
Collaborator Author

@willbradshaw Given how minor this is, would this go under v2.5.3.1, or v2.5.4?

@willbradshaw
Copy link
Contributor

This is going in before the PR that will implement the new version system, so just increment the third number.

@harmonbhasin harmonbhasin changed the base branch from dev to master January 13, 2025 17:51
@harmonbhasin harmonbhasin dismissed their stale review January 13, 2025 17:51

The base branch was changed.

@harmonbhasin harmonbhasin force-pushed the simonleandergrimm-patch-1 branch from eb3fa31 to 215281a Compare January 13, 2025 17:58
@harmonbhasin
Copy link
Collaborator

@willbradshaw this is ready for you to look at, I've updated the CHANGELOG

@willbradshaw willbradshaw marked this pull request as ready for review January 13, 2025 18:19
@willbradshaw
Copy link
Contributor

@simonleandergrimm I merged master into this branch before merging and now test-run-dev-se is failing?

@willbradshaw
Copy link
Contributor

Hmm now it works

@simonleandergrimm
Copy link
Collaborator Author

simonleandergrimm commented Jan 13, 2025 via email

@willbradshaw willbradshaw merged commit 1a04337 into master Jan 14, 2025
5 checks passed
@willbradshaw willbradshaw deleted the simonleandergrimm-patch-1 branch January 14, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willbradshaw willbradshaw willbradshaw approved these changes

@harmonbhasin harmonbhasin harmonbhasin left review comments

Assignees

@simonleandergrimm simonleandergrimm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simonleandergrimm @willbradshaw @harmonbhasin