Check required in Bootstrap4.1 js based on BootstrapDialog.js Modal #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BootstrapDialogModal.ORIGINAL_BODY_PADDING's value may be "0 px",so it's should add parseInt function
fixed ORIGINAL_BODY_PADDING's value type bug
The way to judge whether in CommonJs style can not distinguish real CommonJs from electron, will case BootstrapDialog object set to window.module.exports. Same problem may occur in node webkit,but I do not test this situation.
Allow to initialize the buttons in disabled state
Author: codepiano <[email protected]> Date: Thu Nov 5 23:07:50 2015 +0800 Add code to distinguish cmd and electron envirmonment The way to judge whether in CommonJs style can not distinguish real CommonJs from electron, will case BootstrapDialog object set to window.module.exports. Same problem may occur in node webkit,but I do not test this situation.
Add code to distinguish cmd and electron envirmonment
Conflicts: dist/js/bootstrap-dialog.min.js
Add the license to the bower.json file. This is needed by some tools (e.g. http://www.webjars.org/bower).
Merging without a doubt! Thank you.
Hotkey option added for confirmation dialog and alert.
Merging refs #294
add Accessiblility on the close button
…tributes Add support for data attributes on buttons
Allow a mouseOver text for buttons
Add Examples of data attributes on buttons
Credit due to @franciscocsysteames
Fix scrolling issue #331
Fix double submit when ok button is focused (#333)
|
Good Work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
function Modal(element, config) {
this._config = this._getConfig(config);
this._element = element;
if($(this._element).hasClass("bootstrap-dialog"))
{
var element=this._element.get(0);
this._element=element;
}
this._dialog = $$$1(element).find(Selector.DIALOG)[0];
this._backdrop = null;
this._isShown = false;
this._isBodyOverflowing = false;
this._ignoreBackdropClick = false;
this._scrollbarWidth = 0;
} // Getters