Simplify service by using singletons

nabsul · Feb 12, 2022 · 6248f72 · 6248f72
1 parent b3ddd41
commit 6248f72
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 33 deletions.
diff --git a/Program.cs b/Program.cs
@@ -8,5 +8,5 @@
 Host.CreateDefaultBuilder(args)
     .ConfigureAppConfiguration((ctx, cfg) => cfg.AddEnvironmentVariables())
     .ConfigureWebHostDefaults(webBuilder => webBuilder.UseStartup<Startup>())
-    .ConfigureServices(services => services.AddHostedService<RenewalServiceWrapper>())
+    .ConfigureServices(services => services.AddHostedService<RenewalService>())
     .Build().Run();
diff --git a/Services/KCertClient.cs b/Services/KCertClient.cs
@@ -1,7 +1,6 @@
 using k8s.Models;
 using KCert.Models;
 using Microsoft.Extensions.Logging;
-using Microsoft.Rest;
 using System;
 using System.Collections.Generic;
 using System.Linq;

diff --git a/Services/RenewalServiceWrapper.cs b/Services/RenewalServiceWrapper.cs
diff --git a/Startup.cs b/Startup.cs
@@ -2,6 +2,7 @@
 using Microsoft.AspNetCore.Hosting;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Hosting;
+using System;
 using System.Linq;
 using System.Reflection;
 
@@ -33,8 +34,13 @@ public void Configure(IApplicationBuilder app, IWebHostEnvironment env)
 
     private static void AddKCertServices(IServiceCollection services)
     {
+        Console.WriteLine("Adding KCert services");
         var serviceTypes = Assembly.GetExecutingAssembly().GetTypes()
-            .Where(t => t.GetCustomAttribute<ServiceAttribute>() != null)
-            .Select(t => services.AddScoped(t));
+            .Where(t => t.GetCustomAttribute<ServiceAttribute>() != null);
+
+        foreach (var t in serviceTypes)
+        {
+            services.AddSingleton(t);
+        }
     }
 }