Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix code coverage collection #12443

Merged
merged 1 commit into from
Jan 6, 2025
Merged

ci: Fix code coverage collection #12443

merged 1 commit into from
Jan 6, 2025

Conversation

netroy
Copy link
Member

@netroy netroy commented Jan 3, 2025

Summary

#12434 Broke code-coverage collection on master.

This PR

  1. Changes tests on master to run the full suite
  2. Sets up codecov.yml so that we can maintain this file in this repo instead of in the codecov UI
  3. Enables carryforward flag to allow uploading partial code-coverage

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Jan 3, 2025
@netroy netroy changed the title ci: Fix code coverage collection, and start grouping coverage using codecov tags ci: Fix code coverage collection Jan 3, 2025
@netroy netroy force-pushed the fix-ci-turborepo-cache branch 2 times, most recently from d53f99a to 75a6390 Compare January 3, 2025 14:43
@netroy netroy force-pushed the fix-ci-turborepo-cache branch from 75a6390 to 87ceb4a Compare January 3, 2025 15:15
@netroy netroy marked this pull request as ready for review January 3, 2025 15:16
Copy link
Contributor

github-actions bot commented Jan 6, 2025

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Jan 6, 2025

n8n    Run #8581

Run Properties:  status check failed Failed #8581  •  git commit 87ceb4a1ec: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project n8n
Branch Review fix-ci-turborepo-cache
Run status status check failed Failed #8581
Run duration 04m 37s
Commit git commit 87ceb4a1ec: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Committer कारतोफ्फेलस्क्रिप्ट™
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 443
View all changes introduced in this branch ↗︎

Tests for review

Failed  14-mapping.cy.ts • 1 failed test

View Output Video

Test Artifacts
Data mapping > maps expressions from json view Test Replay Screenshots Video
Failed  39-import-workflow.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  2111-ado-support-pinned-data-in-expressions.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  1858-PAY-can-use-context-menu.ts • 0 failed tests

View Output

Test Artifacts
Failed  10-settings-log-streaming.cy.ts • 0 failed tests

View Output

Test Artifacts

The first 5 failed specs are shown, see all 22 specs in Cypress Cloud.

@netroy netroy merged commit f043ff1 into master Jan 6, 2025
36 of 39 checks passed
@netroy netroy deleted the fix-ci-turborepo-cache branch January 6, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants