fix(editor): Fix Multi option parameter expression when the value is an array #12430
+8
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
|
@ShireenMissi I would say this change should be scoped to multi-options input, now it would affect all inputs, that could cause some regressions |
ShireenMissi
force-pushed
the
node-1535-multi-options-component-dont-show-error-when-using-array-in-expression
branch
from
ec14da6 to
f5ad7d1
Compare
michael-radency
approved these changes
Jan 3, 2025
|
|
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
node-1535-multi-options-component-dont-show-error-when-using-array-in-expression
|
| Run status |
|
| Run duration | 04m 51s |
| Commit |
|
| Committer | Shireen Missi |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
484
|
| View all changes introduced in this branch ↗︎ | |
ShireenMissi
force-pushed
the
node-1535-multi-options-component-dont-show-error-when-using-array-in-expression
branch
from
4d4dbaa to
7952f9c
Compare
michael-radency
approved these changes
Jan 6, 2025
|
✅ All Cypress E2E specs passed |
ShireenMissi
deleted the
node-1535-multi-options-component-dont-show-error-when-using-array-in-expression
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In multi option parameters, the array is an acceptable value for expressions
This PR:
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-1535/multi-options-component-dont-show-error-when-using-array-in-expression
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)