Skip to content

Commit

Permalink
qga-win: Enable 'can-offline' field in 'guest-get-vcpus' reply
Browse files Browse the repository at this point in the history
The QGA schema states:

@can-offline: Whether offlining the VCPU is possible. This member
               is always filled in by the guest agent when the structure
               is returned, and always ignored on input (hence it can be
               omitted then).

Currently 'can-offline' is missing entirely from the reply. This causes
errors in libvirt which is expecting the reply to be compliant with the
schema docs.

BZ#1438735: https://bugzilla.redhat.com/show_bug.cgi?id=1438735

Signed-off-by: Sameeh Jubran <[email protected]>
Reviewed-by: Eric Blake <[email protected]>
Cc: [email protected]
Signed-off-by: Michael Roth <[email protected]>
  • Loading branch information
Sameeh Jubran authored and mdroth committed Apr 27, 2017
1 parent f342cc9 commit 5485855
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion qga/commands-win32.c
Original file line number Diff line number Diff line change
Expand Up @@ -1344,7 +1344,7 @@ GuestLogicalProcessorList *qmp_guest_get_vcpus(Error **errp)
vcpu = g_malloc0(sizeof *vcpu);
vcpu->logical_id = current++;
vcpu->online = true;
vcpu->has_can_offline = false;
vcpu->has_can_offline = true;

entry = g_malloc0(sizeof *entry);
entry->value = vcpu;
Expand Down

0 comments on commit 5485855

Please sign in to comment.