Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
myyrakle
reviewed
Mar 20, 2024
|
|
||
| let value = (header, Vec::new()); | ||
|
|
||
| /// TODO |
There was a problem hiding this comment.
todo 처리를 하려면 todo! 매크로를 쓰는 것도 좋은 방법
src/wal/wal.rs
Outdated
| let mut wal = Wal::default(); | ||
|
|
||
| let mut wal_metadata = get_target_basepath(); | ||
| wal_metadata.push("current_wal_index"); |
There was a problem hiding this comment.
추후에 상단에 const로 정의해놓겠습니다.
src/server/server.rs
Outdated
| @@ -29,14 +32,22 @@ impl Server { | |||
|
|
|||
| let (request_sender, mut request_receiver) = mpsc::channel::<ChannelRequest>(1000); | |||
|
|
|||
| // shared WAL | |||
| // wal struct을 생성, Arc로 관리 | |||
| let shared_wal = Arc::new(Wal::new().await); | |||
There was a problem hiding this comment.
- wal을 글로벌로 하나만 두는게 의도한 건가요? 추후 wal을 테이블이나 블럭 단위로 분리할 계획인가요?
- 그리고 저걸로 뭔가 mutation을 하려면 Mutex로 바꿔야할 것 같은데 맞나요?
There was a problem hiding this comment.
- 의도한게 맞습니다. 레고드에 테이블 정보랑 데이터베이스 정보가 다 들어있습니다.
- Mutex로 바꾸는게 맞는 것 같습니다.
src/wal/wal.rs
Outdated
| use super::{format::{BinaryFormatterImpl, LogFileHeader, MAGIC_NUMBER, VERSION}, record::LogRecord}; | ||
|
|
||
| #[derive(Clone, Debug, Default)] | ||
| pub struct Wal { |
There was a problem hiding this comment.
- 식별자명은 Wal이 나을까요? WAL이 나을까요? 이건 선택의 영역일 것 같네요.
- 타입명이 더 명확하면 좋지 않을까 싶군요. WalManager인지 뭔지 명확한 역할이 타입명에 드러나지 않는 것 같아서
There was a problem hiding this comment.
- WalManager가 괜찮을 것 같습니다. 다음 커밋 때 적용시키겠습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved: #76
설명
간단하게 해당 PR이 어떤 내용인지 작성합니다. 이슈를 통해서 충분히 설명이 가능 하다고 생각하면 resolved만 작성하시면 됩
니다.