Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed security issue and ci #49

Closed
wants to merge 2 commits into from
Closed

Fixed security issue and ci #49

wants to merge 2 commits into from

Conversation

dorayakikun
Copy link

Fixed below issue. (and CI)

https://www.npmjs.com/advisories/786

@codecov
Copy link

codecov bot commented Feb 20, 2019

Codecov Report

Merging #49 into master will increase coverage by 1.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
+ Coverage   83.93%   85.05%   +1.11%     
==========================================
  Files          17       17              
  Lines         610      562      -48     
==========================================
- Hits          512      478      -34     
+ Misses         98       84      -14
Impacted Files Coverage Δ
lib/utils/apply-action.js 62.5% <0%> (-1.39%) ⬇️
lib/utils/copy-file.js 70.45% <0%> (-0.7%) ⬇️
lib/utils/watcher.js 84.37% <0%> (+2.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 692b67b...d44d882. Read the comment docs.

Copy link

@bcomnes bcomnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would love to see this land!

@danielfigueiredo
Copy link

danielfigueiredo commented Mar 4, 2019

👍 to see this landing, thanks for the PR!
There are currently two duplicated issues related to this:
#47
#48

@dorayakikun
Copy link
Author

@mysticatea Could you review it?

@antipalindrome
Copy link

@mysticatea This would be great if we could get it. This is the only thing erroring on my audits!

@marcospgp
Copy link

@mysticatea Please have a look

@TidyIQ
Copy link

TidyIQ commented May 28, 2019

It seems like this project has been abandoned by @mysticatea

Perhaps you could fork this and create a new npm package?

@bcomnes
Copy link

bcomnes commented May 28, 2019

I think declaring abandon is a leap since it’s still works perfectly well. My guess is it’s a matter of notification vs abandonment.

Has anyone tried reaching out via other channels yet?

@McSam27
Copy link

McSam27 commented Jul 9, 2019

Any updates on this? Is there a maintained fork? Or is there any news from mystic?

@bcomnes
Copy link

bcomnes commented Jul 10, 2019

I emailed @mysticatea a few days ago but haven't heard back.

@bcomnes
Copy link

bcomnes commented Aug 26, 2019

I never heard back. No problem.

In the meantime, I forked to cpx2 here: https://github.com/bcomnes/cpx2/pull/1/files

It still has the cpx bin name, so it can be swapped out without any changes to code bases. I use it on lots of things, so I'll try to keep it up to date as needed with greenkeeper and such. I don't have any large refactoring or plans to change it at all. Perhaps one day we can upstream the maintenance work ✌️

@jsomsanith-tlnd
Copy link

Hi, this PR hasn't moved since August. Do you have any idea when this will be merged/released ?
Thank you for your time and work BTW :)

@koresar
Copy link

koresar commented Nov 14, 2019

TL;DR: the solution is to remove unmaintined cpx and use identical but maintained cpx2.

Thanks @bcomnes

@dorayakikun
Copy link
Author

I think it will be migrated to cpx2 in the future so that I will close it.
Thanks to @bcomnes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants