-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed security issue and ci #49
Fixed security issue and ci #49
Conversation
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
==========================================
+ Coverage 83.93% 85.05% +1.11%
==========================================
Files 17 17
Lines 610 562 -48
==========================================
- Hits 512 478 -34
+ Misses 98 84 -14
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would love to see this land!
@mysticatea Could you review it? |
@mysticatea This would be great if we could get it. This is the only thing erroring on my audits! |
@mysticatea Please have a look |
It seems like this project has been abandoned by @mysticatea Perhaps you could fork this and create a new npm package? |
I think declaring abandon is a leap since it’s still works perfectly well. My guess is it’s a matter of notification vs abandonment. Has anyone tried reaching out via other channels yet? |
Any updates on this? Is there a maintained fork? Or is there any news from mystic? |
I emailed @mysticatea a few days ago but haven't heard back. |
I never heard back. No problem. In the meantime, I forked to cpx2 here: https://github.com/bcomnes/cpx2/pull/1/files It still has the |
Hi, this PR hasn't moved since August. Do you have any idea when this will be merged/released ? |
TL;DR: the solution is to remove unmaintined Thanks @bcomnes |
I think it will be migrated to cpx2 in the future so that I will close it. |
Fixed below issue. (and CI)
https://www.npmjs.com/advisories/786