Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrated global variables in the gval language #207

Merged
merged 6 commits into from
Dec 30, 2024
Merged

Integrated global variables in the gval language #207

merged 6 commits into from
Dec 30, 2024

Conversation

Ismail731404
Copy link
Member

No description provided.

@Ismail731404 Ismail731404 self-assigned this Dec 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024 •
edited
Loading

Go test coverage: 11.7% for commit e1f1793
⚠️ 22 of 51 packages have zero coverage.
  • github.com/myrteametrics/myrtea-engine-api/v5
  • github.com/myrteametrics/myrtea-engine-api/v5/docs
  • github.com/myrteametrics/myrtea-engine-api/v5/internals/app
  • github.com/myrteametrics/myrtea-engine-api/v5/internals/config/connectorconfig
  • github.com/myrteametrics/myrtea-engine-api/v5/internals/config/esconfig
  • github.com/myrteametrics/myrtea-engine-api/v5/internals/config/externalconfig
  • github.com/myrteametrics/myrtea-engine-api/v5/internals/connector
  • github.com/myrteametrics/myrtea-engine-api/v5/internals/evaluator
  • github.com/myrteametrics/myrtea-engine-api/v5/internals/explainer
  • github.com/myrteametrics/myrtea-engine-api/v5/internals/explainer/action
  • github.com/myrteametrics/myrtea-engine-api/v5/internals/explainer/draft
  • github.com/myrteametrics/myrtea-engine-api/v5/internals/explainer/issues
  • github.com/myrteametrics/myrtea-engine-api/v5/internals/explainer/rootcause
  • github.com/myrteametrics/myrtea-engine-api/v5/internals/metrics
  • github.com/myrteametrics/myrtea-engine-api/v5/internals/router
  • github.com/myrteametrics/myrtea-engine-api/v5/internals/router/oidc
  • github.com/myrteametrics/myrtea-engine-api/v5/internals/rule
  • github.com/myrteametrics/myrtea-engine-api/v5/internals/search
  • github.com/myrteametrics/myrtea-engine-api/v5/internals/security/roles
  • github.com/myrteametrics/myrtea-engine-api/v5/internals/security/users
  • github.com/myrteametrics/myrtea-engine-api/v5/internals/variablesconfig
  • github.com/myrteametrics/myrtea-engine-api/v5/plugins/baseline
View coverage for all packages 
# Package Name                                                                   | Coverage
- github.com/myrteametrics/myrtea-engine-api/v5                                  |     0.0%
- github.com/myrteametrics/myrtea-engine-api/v5/docs                             |     0.0%
- github.com/myrteametrics/myrtea-engine-api/v5/internals/app                    |     0.0%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/calendar               |    29.2%
- github.com/myrteametrics/myrtea-engine-api/v5/internals/config/connectorconfig |     0.0%
- github.com/myrteametrics/myrtea-engine-api/v5/internals/config/esconfig        |     0.0%
- github.com/myrteametrics/myrtea-engine-api/v5/internals/config/externalconfig  |     0.0%
- github.com/myrteametrics/myrtea-engine-api/v5/internals/connector              |     0.0%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/coordinator            |     7.2%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/email                  |    72.4%
- github.com/myrteametrics/myrtea-engine-api/v5/internals/evaluator              |     0.0%
- github.com/myrteametrics/myrtea-engine-api/v5/internals/explainer              |     0.0%
- github.com/myrteametrics/myrtea-engine-api/v5/internals/explainer/action       |     0.0%
- github.com/myrteametrics/myrtea-engine-api/v5/internals/explainer/draft        |     0.0%
- github.com/myrteametrics/myrtea-engine-api/v5/internals/explainer/issues       |     0.0%
- github.com/myrteametrics/myrtea-engine-api/v5/internals/explainer/rootcause    |     0.0%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/export                 |    60.7%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/fact                   |    53.8%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/fact/lexer             |   100.0%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/handlers               |     3.8%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/handlers/render        |     9.8%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/history                |     2.0%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/ingester               |    10.8%
- github.com/myrteametrics/myrtea-engine-api/v5/internals/metrics                |     0.0%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/modeler                |    27.7%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/models                 |     4.5%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/notifier               |    36.4%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/notifier/notification  |    33.5%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/processor              |    36.6%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/reader                 |     8.5%
- github.com/myrteametrics/myrtea-engine-api/v5/internals/router                 |     0.0%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/router/auth            |    75.0%
- github.com/myrteametrics/myrtea-engine-api/v5/internals/router/oidc            |     0.0%
- github.com/myrteametrics/myrtea-engine-api/v5/internals/rule                   |     0.0%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/scheduler              |     6.2%
- github.com/myrteametrics/myrtea-engine-api/v5/internals/search                 |     0.0%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/security/permissions   |    30.3%
- github.com/myrteametrics/myrtea-engine-api/v5/internals/security/roles         |     0.0%
- github.com/myrteametrics/myrtea-engine-api/v5/internals/security/users         |     0.0%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/service                |    73.9%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/situation              |     6.5%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/tasker                 |    14.8%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/tests                  |    36.6%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/utils                  |   100.0%
+ github.com/myrteametrics/myrtea-engine-api/v5/internals/utils/queryutils       |    77.8%
- github.com/myrteametrics/myrtea-engine-api/v5/internals/variablesconfig        |     0.0%
+ github.com/myrteametrics/myrtea-engine-api/v5/plugins                          |    57.9%
- github.com/myrteametrics/myrtea-engine-api/v5/plugins/baseline                 |     0.0%
+ github.com/myrteametrics/myrtea-engine-api/v5/plugins/baseline/proto           |     5.4%
+ github.com/myrteametrics/myrtea-engine-api/v5/plugins/pluginutils              |     4.3%
+ github.com/myrteametrics/myrtea-engine-api/v5/plugins/standalone               |     8.9%

@SchawnnDev SchawnnDev marked this pull request as draft December 10, 2024 10:32
@Ismail731404
Update myrtea-sdk to latest version
ce202dd 
Bumped myrtea-sdk/v5 to version v5.1.6-0
@Ismail731404
Update myrtea-sdk to the latest version
3285e05 
Upgraded myrtea-sdk/v5 dependency to version v5.1.6-0.20241212103740-2c397073ca30 in `go.mod` and `go.sum`. This ensures compatibility with the latest changes and improvements in the SDK.
@Ismail731404 Ismail731404 marked this pull request as ready for review December 12, 2024 10:56
@Ismail731404
Refactor to use transaction-bound statement builder
8aae519
@Ismail731404
Refactor variable handling to use expression.G() API
f9b608f 
Updated calls from `expression.GlobalVars` to the simplified `expression.G()` API for improved readability and maintainability. Also updated the `myrtea-sdk` dependency to the latest version in `go.mod` and `go.sum`.
@Ismail731404
Update myrtea-sdk to stable v5.1.6 release
3e69393 
Replaced the pre-release version of myrtea-sdk with the stable v5.1.6 version in both `go.mod` and `go.sum`. This ensures better stability and compatibility for the dependency.
@SchawnnDev SchawnnDev changed the title Integration of global variables in the gval language by default Integrated global variables in the gval language Dec 30, 2024
@Ismail731404 Ismail731404 merged commit a06e638 into master Dec 30, 2024
1 check passed
@Ismail731404 Ismail731404 deleted the feature/sync-crud-global-variables-sdk branch December 30, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SchawnnDev SchawnnDev SchawnnDev approved these changes

@cedricablain cedricablain Awaiting requested review from cedricablain cedricablain is a code owner

Assignees

@Ismail731404 Ismail731404

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ismail731404 @SchawnnDev