Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rework project structure #255

Merged
merged 90 commits into from
May 17, 2024
Merged

chore: rework project structure #255

merged 90 commits into from
May 17, 2024

Conversation

JeremyPansier
Copy link
Member

Checklist:

  • The code follows our code conventions.
  • Important principle changes have been documented in the wiki.
  • The new code is covered by unit tests with assertions.
  • The behaviour node and UI have been manually tested and is as expected.
  • The squash commit message follows our conventions.

@JeremyPansier JeremyPansier linked an issue Nov 14, 2023 that may be closed by this pull request
Rework project structure #243
Closed
@JeremyPansier JeremyPansier self-assigned this Nov 14, 2023
@sonarqubecloud SonarQubeCloud

This comment was marked as outdated.

Sign in to view
@JeremyPansier JeremyPansier force-pushed the 243-refactor-blockchain-and-transactions-pool branch from 8475e8f to 3f4cae5 Compare March 15, 2024 08:16
github-advanced-security[bot]
github-advanced-security bot found potential problems May 17, 2024
View reviewed changes
deploy/helm/templates/statefulset.yaml
@@ -66,6 +66,8 @@
memory: {{ $container.resources.requests.memory }}
limits:
memory: {{ $container.resources.limits.memory }}
cpu: {{ $container.resources.limits.cpu }}

Check warning

Code scanning / SonarCloud

CPU limits should be enforced

<!--SONAR_ISSUE_KEY:AY-GP4bDecbr4OQ-3_9J-->Specify a CPU limit for this container. <p>See more on <a href="https://sonarcloud.io/project/issues?id=my-cloud_ruthenium&issues=AY-GP4bDecbr4OQ-3_9J&open=AY-GP4bDecbr4OQ-3_9J&pullRequest=255">SonarCloud</a></p>
deploy/helm/templates/statefulset.yaml
@@ -66,6 +66,8 @@
memory: {{ $container.resources.requests.memory }}
limits:
memory: {{ $container.resources.limits.memory }}
cpu: {{ $container.resources.limits.cpu }}
ephemeral-storage: {{ $container.resources.limits.storage }}

Check warning

Code scanning / SonarCloud

Storage limits should be enforced

<!--SONAR_ISSUE_KEY:AY-GP4bDecbr4OQ-3_9K-->Specify a storage limit for this container. <p>See more on <a href="https://sonarcloud.io/project/issues?id=my-cloud_ruthenium&issues=AY-GP4bDecbr4OQ-3_9K&open=AY-GP4bDecbr4OQ-3_9K&pullRequest=255">SonarCloud</a></p>
gwenall
gwenall requested changes May 17, 2024
View reviewed changes
deploy/helm/templates/statefulset.yaml Outdated Show resolved Hide resolved
@JeremyPansier JeremyPansier requested a review from gwenall May 17, 2024 11:58
gwenall
gwenall requested changes May 17, 2024
View reviewed changes
deploy/helm/values.yaml Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
18 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.0% Coverage on New Code
1.2% Duplication on New Code

See analysis details on SonarCloud

@JeremyPansier JeremyPansier merged commit f055313 into main May 17, 2024
8 checks passed
@JeremyPansier JeremyPansier deleted the 243-refactor-blockchain-and-transactions-pool branch May 17, 2024 14:30
@JeremyPansier JeremyPansier linked an issue May 17, 2024 that may be closed by this pull request
Set registry synchronization time in configuration #260
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwenall gwenall gwenall approved these changes

Assignees

@JeremyPansier JeremyPansier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set registry synchronization time in configuration Rework project structure
2 participants
@JeremyPansier @gwenall