Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add shell-completion commands #600

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nimrod-a
Copy link
Contributor

This PR is a WIP to add a shell-completion command to mvt-ios and mvt-android.

As discussed in #589, there is currently no suitable library to implement this feature without substantial performance impact.

I have therefor created a modified fork of the most popular click autocomplete library (auto-click-auto), which I named quick-click-auto.

You can read more about it here

It still needs some working on, but will hopefully do its job in the near future. I will give an update once I have done some more testing!

@nimrod-a
Copy link
Contributor Author

Update:

The shell-completion command should work as expected now!
I would be happy about people testing this feature :)

For testing:

git clone -b feature/command_completion_command https://github.com/nimrod-a/mvt.git \
&& cd mvt \
&& python3 -m venv .venv && source .venv/bin/activate \
&& pip install . \
&& mvt-ios shell-completion # or mvt-android

Then reopen the terminal or run a new with bash or `zsh.
Command completion should be enabled now.

It works by:

  • Generating the command completion scripts
  • Editing the shell configuration to automatically sources the generated files to the shell.

It should not slow down shell responsiveness as much as the eval implementation did, as the scripts are not generated every time the shell is opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant