Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support makeStyles (hook-based JSS?) from @material-ui/styles #50

Open
cmeeren opened this issue Jan 2, 2019 · 2 comments
Open

Support makeStyles (hook-based JSS?) from @material-ui/styles #50

cmeeren opened this issue Jan 2, 2019 · 2 comments

Comments

@cmeeren
Copy link
Contributor

cmeeren commented Jan 2, 2019

In many samples on the Material-UI docs, e.g. App Bar with a primary search field, one can now choose between JSS using withStyles (HOC) or makeStyles (React hook-based, AFAIK). makeStyles is defined in @material-ui/styles.

It doesn't seem that fable-material-ui supports makeStyles yet. Would it be possible to add support for it? And could this perhaps entirely avoid the problem/workarounds from #4?

@mvsmal
Copy link
Owner

mvsmal commented Jan 3, 2019

React hooks are not released yet, React team promised to deliver it in version 16.7, but according to this post, they postponed it till the next release.
@material-ui/styles are also in experimental (alpha) stage, so I didn't spend time on them yet.

I am thinking of creating a separate package, as @material-ui does, but not sure yet. Once the APIs are stable and released, I will create bindings for them, for sure. I will try to play around with it sooner, if time allows.
Btw, PRs are welcome 😉

@cmeeren
Copy link
Contributor Author

cmeeren commented Jan 3, 2019

according to this post, they postponed it till the next release.

Ah, I see. Looking forward to the release and your bindings.

I don't have much time or energy to spare, but I'll definitely consider PRs when I have itches to scratch. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants