Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --find0 and --list0 flags #1097

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

sdavids
Copy link
Contributor

@sdavids sdavids commented Sep 20, 2024

@sdavids
Copy link
Contributor Author

sdavids commented Sep 20, 2024

One thing I noticed but I did not want to create a new issue or pollute this PR:

go 1.19

should it not be the same as:

sh/go.mod

Line 3 in 57b7613

go 1.22

@sdavids sdavids force-pushed the users/sdavids/feat/null-char-list-find branch from 4ccbf3a to 165f3a8 Compare October 1, 2024 15:09
Copy link
Owner

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, just two nits

cmd/shfmt/main.go Outdated Show resolved Hide resolved
cmd/shfmt/main.go Outdated Show resolved Hide resolved
@sdavids sdavids force-pushed the users/sdavids/feat/null-char-list-find branch from 165f3a8 to dde54b1 Compare October 1, 2024 15:20
Copy link
Owner

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

To separate output filenames with null bytes rather than newlines,
matching the format expected by tools such as `xargs -0`.

Fixes mvdan#1096.

Signed-off-by: Sebastian Davids <[email protected]>
@mvdan mvdan force-pushed the users/sdavids/feat/null-char-list-find branch from dde54b1 to 000aeaa Compare November 18, 2024 23:58
@mvdan
Copy link
Owner

mvdan commented Nov 18, 2024

FYI force-pushed here to resolve the conflict, squash the commits, and write a slightly longer commit message.

@mvdan mvdan merged commit fceab2f into mvdan:master Nov 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants