Feat: add info about DSP to StreamDetails #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelveldt
reviewed
Jan 14, 2025
marcelveldt
reviewed
Jan 14, 2025
Instead of a separate entry for the leader, DSPDetails now has a is_leader field.
maximmaxim345
force-pushed
the
feat/dsp-streamdetails
branch
from
315b8cb to
ee27134
Compare
marcelveldt
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow the player to display information about the applied DSP (including all individual devices in grouped playback), including a reason in case the DSP was disabled by Music Assistant.
A PR for server and fronted will follow later.