Unix Makefile: Discard unnecessary architecture checks #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike the Mupen64Plus Core, which is sensitive to the architecture it's compiled for due to its just-in-time compilers, this project does not require architecture-specific glue code, only operating system checks to load dynamic libraries and the presence of a well-behaving port of SDL and OpenGL (ES) on the platform. M64P_BIG_ENDIAN is not used for any decisions in this plugin, either. Delete the big-endian processor checks.
|
Mmmh... after some investigations, we should maybe not remove everything. There is a lot of places where the Makefile try to avoid compilation problems on various architectures using those values. What I suggest is to add the architecture you want to support here. |
|
Alright, so after building for MIPS with NO_ASM = 0, I see that there is indeed architecture-specific stuff, namely a Gonna kill this pull request for now and remake it with a MIPS support stanza instead. That, or perhaps you want |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the benefit of #46.