Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Upgrade clang-format 10 -> 11 #10

Closed
wants to merge 2 commits into from
Closed

CI: Upgrade clang-format 10 -> 11 #10

wants to merge 2 commits into from

Conversation

Kissaki
Copy link
Member

@Kissaki Kissaki commented Mar 12, 2024

No description provided.

@Krzmbrzl
Copy link
Member

What's the reason for this switch? Presumably this collides with existing formatting in this repo, no? 🤔

@Kissaki
Copy link
Member Author

Kissaki commented Mar 13, 2024

Isn't the formatting defined in .clang-format?

I would expect upgrading clang-format to not lead to changes?

I initially set this branch and PR up trying to fix the build/checks in master, but I was able to fix it with upgrading the used GitHub action, that was sufficient. I left this open planning to (maybe/probably) upgrade the clang-format version expecting no difference in the actual formatting verification, only an upgrade in tooling.

@davidebeatrici
Copy link
Member

Unfortunately yes, different clang-format versions can lead to a different output due to bug fixes and overall changes.

@Krzmbrzl
Copy link
Member

Yeah, clang-format only produces equal outputs for equal versions. That's a big shame, but that's how it is.

@Kissaki
Copy link
Member Author

Kissaki commented Mar 13, 2024

Shall I discard this then?

The action has versions up to 18, which I would have tried.

If the pr checks do not report any issue then the upgrade should be fine even without code changes!?

At least the current PR state upgrading from 10 to 11 doesn't report and changes!?

In the log I don't even see a success message. So I assume it only reports issues? https://github.com/mumble-voip/mumble-json-bridge/actions/runs/8253456912/job/22575337407?pr=10

@Kissaki
Copy link
Member Author

Kissaki commented Mar 13, 2024

ok, v 18 fails :D

I guess I'll close instead of finding max version, nobody's using this project anyway

@Kissaki Kissaki closed this Mar 13, 2024
@Kissaki Kissaki deleted the ci/clang-format branch March 13, 2024 15:32
@Kissaki
Copy link
Member Author

Kissaki commented Mar 13, 2024

nobody's using this project anyway

I thought I was in mumblekit…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants