Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): use chai throws() & chai-as-promised isRejected() #149

Merged
merged 1 commit into from
Jan 7, 2022

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Jan 4, 2022

No description provided.

@rvagg rvagg requested a review from Gozala January 4, 2022 06:41
@rvagg rvagg force-pushed the rvagg/chai-throws branch from f548ad1 to b40d754 Compare January 4, 2022 06:48
@rvagg
Copy link
Member Author

rvagg commented Jan 4, 2022

failing on the new typescript test suite:

Error: src/main.ts(1,24): error TS2307: Cannot find module 'multiformats/block' or its corresponding type declarations.
Error: src/main.ts(2,24): error TS2307: Cannot find module 'multiformats/hashes/sha2' or its corresponding type declarations.
Error: src/main.ts(3,23): error TS2307: Cannot find module 'multiformats/codecs/json' or its corresponding type declarations.

But why didn't it fail on #142? I even rebased that and it had to run through master successfully to get released. I haven't touched any of these or the tsconfigs that point to these packages. Why now? There hasn't been a new version of typescript between that commit and this.

@rvagg rvagg force-pushed the rvagg/chai-throws branch from b40d754 to 21c74d3 Compare January 6, 2022 00:26
@rvagg
Copy link
Member Author

rvagg commented Jan 6, 2022

fixed with a rebase, thanks to the type checking revert

@rvagg rvagg force-pushed the rvagg/chai-throws branch from 21c74d3 to 9b5258d Compare January 7, 2022 04:46
@rvagg rvagg merged commit 6e4ba86 into master Jan 7, 2022
@rvagg rvagg deleted the rvagg/chai-throws branch January 7, 2022 05:02
@github-actions
Copy link

github-actions bot commented Jan 7, 2022

🎉 This PR is included in version 9.5.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant