[DataGrid] All selectors accept only apiRef as first argument
#16198
+289
−392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-16198--material-ui-x.netlify.app/ |
romgrk
reviewed
Jan 15, 2025
packages/x-data-grid-pro/src/components/GridDataSourceTreeDataGroupingCell.tsx
Outdated
Show resolved
Hide resolved
romgrk
reviewed
Jan 15, 2025
Comment on lines
-46
to
+48
| const loadingSelector = (state: GridStatePremium) => state.dataSource.loading[id] ?? false; | ||
| const errorSelector = (state: GridStatePremium) => state.dataSource.errors[id]; | ||
| const loadingSelector = (apiRefObject: React.RefObject<GridApiPremium>) => | ||
| apiRefObject.current.state.dataSource.loading[id] ?? false; | ||
| const errorSelector = (apiRefObject: React.RefObject<GridApiPremium>) => | ||
| apiRefObject.current.state.dataSource.errors[id]; |
There was a problem hiding this comment.
These should probably be selectors with arguments.
There was a problem hiding this comment.
And rowSelector below as well.
romgrk
reviewed
Jan 15, 2025
Comment on lines
-4
to
+5
| export const gridAggregationStateSelector = (state: GridStatePremium) => state.aggregation; | ||
| export const gridAggregationStateSelector = (apiRef: React.RefObject<GridApiPremium>) => | ||
| apiRef.current.state.aggregation; |
There was a problem hiding this comment.
I wonder if creating a createStateSelector that pre-fetches apiRef.current.state could be useful for readability.
There was a problem hiding this comment.
Creating a type like GridApiRef*** to make React.RefObject<GridApi***> more compact could also be nice.
There was a problem hiding this comment.
I was about to do that, but have to resolve rendering issues first 🙂
romgrk
reviewed
Jan 15, 2025
Comment on lines
229
to
231
| const getPinnedColumns = React.useCallback<GridColumnPinningApi['getPinnedColumns']>(() => { | ||
| return gridPinnedColumnsSelector(apiRef.current.state); | ||
| return gridPinnedColumnsSelector(apiRef); | ||
| }, [apiRef]); |
There was a problem hiding this comment.
I wonder if we should deprecate API methods that only call a selector.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11440