msys2-runtime: test Takashi's patches #5147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My idea is that we merge this and give it some exercise in CI to see if we see any more hangs. I think Git for Windows' tests sounded like a better indicator of whether the hangs are fixed or not, though. To that end, I opened git-for-windows/msys2-runtime#81 as well. |
jeremyd2019
force-pushed
the
msys2-runtime-takashi-patches
branch
from
25604e5 to
11efa75
Compare
|
These patches are still a moving target 🤷 |
jeremyd2019
force-pushed
the
msys2-runtime-takashi-patches
branch
2 times, most recently
from
8257f37 to
fa6ee40
Compare
|
These are now in cygwin/master and cygwin-3_5-branch (well, except for the revert, which the original patch was never applied to 3.5). There is still one more hang-related patch pending review though... Also, I kind of think that 3.5.6 will be forthcoming once these are in, so maybe not worth backporting if we're just going to update to 3.5.6 right after? |
As these are for testing, apply them separately and leave the msys2-runtime PR as a draft for now (msys2/msys2-runtime#253).
jeremyd2019
force-pushed
the
msys2-runtime-takashi-patches
branch
from
fa6ee40 to
284a32a
Compare
|
All the patches are now in cygwin/master and cygwin-3_5-branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As these are for testing, apply them separately and leave the msys2-runtime PR as a draft for now
(msys2/msys2-runtime#253).