Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustup: new, 1.27.1 #20923

Closed

Conversation

500-internal-server-error

Fixes #16145

@ognevny
Copy link
Collaborator

ognevny commented May 16, 2024

why ucrt64 only?

@500-internal-server-error
Copy link
Author

Ah, I forgot to add the other arches - when I write PKGBUILDs for myself, I usually only specify ucrt since that's the only one I use. I'll add the other ones.

@ognevny
Copy link
Collaborator

ognevny commented May 16, 2024

fix rustup-profile.sh to use ${MINGW_PREFIX}

mingw-w64-rustup/PKGBUILD Outdated Show resolved Hide resolved
mingw-w64-rustup/PKGBUILD Outdated Show resolved Hide resolved
"${MINGW_PACKAGE_PREFIX}-xz"
"${MINGW_PACKAGE_PREFIX}-zstd"
)
makedepends=("${MINGW_PACKAGE_PREFIX}-rust")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the MSYS2 rust is needed to build rustup.
And the 1st thing rustup does it kick out MSYS2 rust.
Not very polite :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:) It builds too if an existing rust install can be found elsewhere (e.g., manual download of rustup-init), with --nodeps, which is how I built this locally initially.

mingw-w64-rustup/PKGBUILD Outdated Show resolved Hide resolved
@500-internal-server-error
Copy link
Author

Bump :) Is there anything else I need to do?

@ognevny
Copy link
Collaborator

ognevny commented May 24, 2024

why did you reset your commit?

@500-internal-server-error
Copy link
Author

Superseded by #20989

Forgot to do the work in a separate branch, updating master on my fork caused merge conflicts :)

@500-internal-server-error
Copy link
Author

why did you reset your commit?

I tried to sync my fork with this repo, which failed with a merge conflict. Because I forgot to add my commits to a separate branch, I cannot my fork's master with this repo's master without rewriting history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add rustup
3 participants