-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustup: new, 1.27.1 #20923
rustup: new, 1.27.1 #20923
Conversation
why ucrt64 only? |
Ah, I forgot to add the other arches - when I write |
fix rustup-profile.sh to use ${MINGW_PREFIX} |
mingw-w64-rustup/PKGBUILD
Outdated
"${MINGW_PACKAGE_PREFIX}-xz" | ||
"${MINGW_PACKAGE_PREFIX}-zstd" | ||
) | ||
makedepends=("${MINGW_PACKAGE_PREFIX}-rust") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the MSYS2 rust is needed to build rustup.
And the 1st thing rustup does it kick out MSYS2 rust.
Not very polite :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:) It builds too if an existing rust install can be found elsewhere (e.g., manual download of rustup-init), with --nodeps
, which is how I built this locally initially.
Bump :) Is there anything else I need to do? |
2d280db
to
62aae5d
Compare
why did you reset your commit? |
Superseded by #20989 Forgot to do the work in a separate branch, updating master on my fork caused merge conflicts :) |
I tried to sync my fork with this repo, which failed with a merge conflict. Because I forgot to add my commits to a separate branch, I cannot my fork's master with this repo's master without rewriting history. |
Fixes #16145