Skip to content

Commit

Permalink
ci: generate dockers in parallel to build-and-test
Browse files Browse the repository at this point in the history
Prior to this commit, docker generation was happening _after_
build-and-test stage.

With this commit pmacct-docker (pmacct docker container generation)
happens in parallel to builders+build-and-test, and only upload
awaits _both_ build-and-test and pmacct-docker, as we don't want
to publish (bleeding-edge tag) images that don't pass all tests.

This cuts some minutes in the pipeline.

Thanks @dcaba for the suggestion
  • Loading branch information
msune committed May 26, 2021
1 parent 5922d73 commit 513c1da
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,6 @@ jobs:
### Step 3: official docker image generation
pmacct-docker:
needs: build-and-test
runs-on: ubuntu-18.04
steps:
- name: Checkout pmacct
Expand Down Expand Up @@ -165,7 +164,7 @@ jobs:
### Step 4: Upload images to dockerhub (bleeding-edge, latest and releases)
publish-dockerhub:
needs: pmacct-docker
needs: [pmacct-docker, build-and-test]
runs-on: ubuntu-18.04
if: github.event_name != 'pull_request'
env:
Expand Down

0 comments on commit 513c1da

Please sign in to comment.