Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve discrepancies between initial run dates and embargo dates of SMILE vs. those of Hera #1414

Open
qu8n opened this issue Feb 24, 2025 · 1 comment

Comments

@qu8n
Copy link
Collaborator

qu8n commented Feb 24, 2025

See Quan's thread with Anne Marie in #smile-pm for the latest.

I spot checked a few of these samples and confirmed that their initial run dates are correct, but only based on the Cohort Complete data in the SMILE database.

The initial run dates from HERA in the join tables above are mostly dated year 2020, but the earliest Cohort Complete event date in the SMILE database is dated year 2022. Is it possible that SMILE is missing some Cohort Complete data?

Neo4j query to spot check initial run date of a sample primary ID:

MATCH (sm:SampleMetadata{primaryId:"06208_R_1"})<-[:HAS_METADATA]-(s:Sample)<-[:HAS_COHORT_SAMPLE]-(c:Cohort)-[:HAS_COHORT_COMPLETE]->(cc:CohortComplete)
RETURN MIN(cc.date)

Notes for discussion:

  • Since initialRunDates are correct based on data CURRENTLY in SMILE, we will need to look into what data is missing from SMILE.
  • To assist with this effort, we will need sample cohort data specifically for the samples that have discrepant initial run dates in TEMPO vs. SMILE
  • If cohort data is missing in SMILE then we need to recover it and/or figure out why it isn't in SMILE

Resolution:

  • Anne Marie provided a mapping of sample-initial run dates that SMILE can use to override the calculated run dates.
  • for the samples that are providing in the mapping above, recalculate their embargo dates and access level values
  • add logic in smile-server during import/update of cohort complete events. If the sample's calculated initial run date is after the initial run date currently stored in the db for that sample then leave the data as is (don't update)
@ao508
Copy link
Collaborator

ao508 commented Feb 26, 2025

Please add your planning poker estimate with Zenhub @qu8n

@qu8n qu8n changed the title Investigate discrepancies between initial run dates and embargo dates of SMILE vs. those of Hera Resolve discrepancies between initial run dates and embargo dates of SMILE vs. those of Hera Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants