Improve population error #453
Conversation
r-ash
force-pushed
the
improve-warnings
branch
from
050d795 to
cd1b566
Compare
| "for model projections. Please review model options", | ||
| "selection to ensure that area level selection is correct.") | ||
| ) | ||
| }) |
There was a problem hiding this comment.
Could the error message here quote the area level and area level label selected?
"Population data not available for selected area level 3 (District). Pleas review model options"
Also I'm think I would remove the "for model projections". We usually use "projections" to refer to the T3/T4/T5 projection, but here this area level selection pertains to everything.
| @@ -329,6 +329,10 @@ naomi_model_frame <- function(area_merged, | |||
| ## of a Spectrum file and then calibrated. Currently no way to know if areas | |||
| ## comparise only part of a Spectrum file, so can't address. | |||
|
|
|||
| if (!all(mf_areas[["area_id"]] %in% unique(population_agesex$area_id))) { | |||
There was a problem hiding this comment.
If the error message is about the area level selected, why is the conditional here referring to the area IDs (not the area level)?
There was a problem hiding this comment.
We don't area level available in the population data to easier to check that these intersect and then pull that in if they don't for the error message if needed
Generate more informative warning when user select area level to generate model estimates for which population data is not available