version 0.3.0 -- updated signing for strings to be correct

mpeyfuss · Jun 1, 2022 · 2d8abfb · 2d8abfb
1 parent 169d93d
commit 2d8abfb
Show file tree

Hide file tree

Showing 3 changed files with 46 additions and 30 deletions.
diff --git a/evm_sc_utils/signers.py b/evm_sc_utils/signers.py
@@ -66,8 +66,7 @@ def __pack_data(abi_types: List[str], values: List) -> bytearray:
                 length = 20
                 val = int(value, 16)
             elif "string" in abi_type.lower():
-                length = len(value)
-                data.extend(value.encode("utf-8"))  # extend in place
+                data.extend(bytes(value, "utf-8"))  # extend in place
 
             if isinstance(val, int):
                 data.extend(bytearray(val.to_bytes(length=length, byteorder="big")))

diff --git a/poetry.lock b/poetry.lock
diff --git a/tests/test_signers.py b/tests/test_signers.py
@@ -70,6 +70,9 @@ def test_address_uint256(self, random_signer):
             ) == sig.messageHash
         )
 
+    def test_string(self, random_signer):
+        assert EIP191Signer.get_signable_message(["string"], ["I have 100€"]).body.hex() == "49206861766520313030e282ac"
+
 
 class Test_Known_Signer:
     # test sending empty lists to sign