Optional content groups in muPDF backend #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbway
commented
Aug 30, 2024
src/ezdxf/addons/drawing/pymupdf.py
Outdated
| try: | ||
| import fitz | ||
| import pymupdf # type: ignore[import-untyped] |
There was a problem hiding this comment.
fitz is a legacy name and mupdf is the new name: source
|
the output of
|
|
I would not add support for exporting turned off or frozen layers, as this is often not the intention of the DXF file creator, although BricsCAD supports this as an option. It is very laborious to implement and test and may break other functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the option for the muPDF backend to tag entities as belonging to 'optional content groups' which are similar to layers in that visibility of entities in the groups can be toggled in supported viewers. muPDF OCG documentation. This feature was requested in #1154 .
The current implementation only outputs visible layers as entities on invisible/hidden layers are filtered out by the frontend. A future improvement could be to use
--all-layers-visibletogether with an option for the backend to set the layer visibility in the output independently from their visibility in the dxf.Some fixes have also been applied to the
ezdxf drawcommand as the--all-layers-visiblehad stopped working.