refactor commit of pending changes

New DXFEntity.commit_pending_changes() method to commit
pending changes before DXF export, like temporary transformations
of ACIS entities.

notes/pages/CHANGELOG.md

@@ -18,7 +18,6 @@ id:: 65e30c28-021e-4c24-ab6e-a9e9fa7c6a51
 	- NEW: support for transformation of [[ACIS]] based entities
 		- the transformation is stored as temporary transformation and will be applied automatically before export
 		- the applied transformation is a transformed anonymous block that contains that [[ACIS]] entity
-	- NEW: method `ezdxf.document.Drawing.apply_temporary_transformations()`, called automatically before DXF export
 	- NEW: function `ezdxf.transform.apply_temporary_transformations()`
 	- CHANGE: class `RenderContext` accepts ctb files as instances of `acadctb.ColorDependentPlotStyles`
 	- CHANGE: replaced the `Designer` class of the `drawing` add-on by a render pipeline with separated render stages

src/ezdxf/document.py

@@ -586,6 +586,9 @@ def write(self, stream: Union[TextIO, BinaryIO], fmt: str = "asc") -> None:
             fmt: "asc" for ASCII DXF (default) or "bin" for binary DXF
 
         """
+        # These changes may alter the document content (create new entities, blocks ...) 
+        # and have to be done before the export and the update of internal structures 
+        # can be done.
         self.commit_pending_changes()
 
         dxfversion = self.dxfversion
@@ -643,6 +646,10 @@ def export_sections(self, tagwriter: AbstractTagWriter) -> None:
 
         tagwriter.write_tag2(0, "EOF")
 
+    def commit_pending_changes(self) -> None:
+        for entity in self.entitydb.values():
+            entity.commit_pending_changes()
+
     def update_all(self) -> None:
         if self.dxfversion > DXF12:
             self.classes.add_required_classes(self.dxfversion)
@@ -1176,17 +1183,6 @@ def set_modelspace_vport(self, height, center=(0, 0), *, dxfattribs=None) -> VPo
         self.header.reset_wcs()
         return vport
 
-    def commit_pending_changes(self) -> None:
-        """Commit all pending changes."""
-        self.apply_temporary_transformations()
-
-    def apply_temporary_transformations(self) -> None:
-        """Apply temporary transformations to all entities in this drawing."""
-        for entity in self.entitydb.values():
-            if isinstance(entity, SupportsTemporaryTransformation):
-                tt = entity.temporary_transformation()
-                tt.apply_transformation(entity)
-
 
 class MetaData(abc.ABC):
     """Manage ezdxf meta-data by dict-like interface. Values are limited to

src/ezdxf/entities/acis.py

@@ -165,6 +165,9 @@ def convert_acis_data(self) -> None:
         if msg:
             logger.info(msg)
 
+    def commit_pending_changes(self) -> None:
+        self._temporary_transformation.apply_transformation(self)
+
     def preprocess_export(self, tagwriter: AbstractTagWriter) -> bool:
         msg = ""
         if tagwriter.dxfversion < const.DXF2013:

src/ezdxf/entities/dxfentity.py

@@ -620,6 +620,13 @@ def _silent_kill(self):  # final - do not override this method!
         del self.doc
         del self.dxf  # check mark for is_alive
 
+    def commit_pending_changes(self) -> None:
+        """Commit all unapplied changes like temporary transformations of ACIS entities.
+
+        (internal API)
+        """
+        pass
+
     def preprocess_export(self, tagwriter: AbstractTagWriter) -> bool:
         """Pre requirement check and pre-processing for export.