Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Solucionado el issue 30. Ahora a los superusers les aparece un boton de ... #50

Merged
merged 2 commits into from
Nov 12, 2013

Conversation

bbotella
Copy link

@bbotella bbotella commented Nov 4, 2013

...delete en cada mencion en la vista index.

Issue30

@ghost ghost assigned sveggiani and sebasmagri Nov 4, 2013
@nukeador
Copy link
Member

nukeador commented Nov 4, 2013

Maybe we'll need some kind of confirmation to avoid accidental deletions.

@bbotella
Copy link
Author

bbotella commented Nov 4, 2013

Sure. And, by the way, is it ok if the link is just available to superusers? Should we check if they are just in the "admin" group?

*** Sorry for the spanish comments. I'm just a newie.

@bbotella
Copy link
Author

bbotella commented Nov 4, 2013

It has been made following admin style.


{% block main_content %}
<h1>
Are you sure?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strings are not l10n friendly.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uops. My bad. Fixed. It won't happen again.

@nukeador
Copy link
Member

nukeador commented Nov 5, 2013

r? @sebasmagri

@bbotella It would be helpful if once this is reviewed you can squash all commit in one:

https://help.github.com/articles/interactive-rebase

And the commit message to follow this format:

"Delete button for admins. Fix #30"

http://mhdev.readthedocs.org/es/latest/git.html#commit-messages

Thanks.

@sebasmagri
Copy link
Member

I've been following this and it looks ok in general. @bbotella please consider @nukeador's suggestions to merge the changes.

Thanks a lot.

Regards,

Bernardo Botella and others added 2 commits November 5, 2013 01:47
Delete button for admins. Fix mozillahispano#30

Added deletion confirmation in delete mention option

I forgot to add delete_mention template

Module not needed removed.

Fixed traslation strings

Delete button for admins. Fix mozillahispano#30

Delete button for admins. Fix mozillahispano#30

Fixed traslation strings in index
@sebasmagri sebasmagri merged commit 618d588 into mozillahispano:django15 Nov 12, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants