Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make advanced search options more discoverable #3510

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Make advanced search options more discoverable #3510

merged 2 commits into from
Jan 7, 2025

Conversation

flodolo
Copy link
Collaborator

@flodolo flodolo commented Jan 7, 2025

Fixes #3502

@flodolo flodolo requested a review from mathjazz January 7, 2025 07:11
mathjazz
mathjazz approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@mathjazz mathjazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to highlight the icons on hover. Other than that, it looks good.

@flodolo
Copy link
Collaborator Author

flodolo commented Jan 7, 2025

It would be nice to highlight the icons on hover. Other than that, it looks good.

Added highlighting (white). I think that piece of code was effectively unused?
df344b1

@mathjazz mathjazz merged commit cf74554 into mozilla:main Jan 7, 2025
5 checks passed
@flodolo flodolo deleted the issue3502 branch January 7, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathjazz mathjazz mathjazz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve visibility of advanced search options
2 participants
@flodolo @mathjazz