Code

Fix new contributor detection logic#3477

Code

Merged

mathjazz merged 6 commits intomozilla:mainmozilla/pontoon:mainfrom mathjazz:new-contributor-notifications-fixmathjazz/pontoon:new-contributor-notifications-fixCopy head branch name to clipboardDec 9, 2024

+83-6

Commits

Commits on Dec 8, 2024

• Change is_new_contributor() to include first translation

  Show description for eaa27e1
  mathjazz

  committed
  eaa27e1

  Copy full SHA for eaa27e1

• Add a unit test

  mathjazz

  committed
  e53ef21

  Copy full SHA for e53ef21

• Do not send the notification if the project manager makes a contribution

  mathjazz

  committed
  14a3a05

  Copy full SHA for 14a3a05

Commits on Dec 9, 2024

• Check if the user is a project contact first, because it doesn't need a DB query

  mathjazz

  committed
  54116a0

  Copy full SHA for 54116a0

• Check that the new contributor notification is only sent for the first contribution

  mathjazz

  committed
  35864b1

  Copy full SHA for 35864b1

• user.is_new_contributor > user.has_one_contribution

  mathjazz

  committed
  ffb2b0b

  Copy full SHA for ffb2b0b