Fix gettext plural forms for non-plural locales

[eemeli]

Fixes #2744

Includes an SQL data migration to fix the ~100 instances of bad data in the pontoon.mozilla.org DB. Most of those were not actually due directly to the parent issue, but the AMO string Version {0} getting a plural form added to it about half a year ago.

After this lands, previously suggested and auto-rejected translations should be re-submitted. As the migration is non-reversible and I managed to apply it locally before taking note of exactly which ones those may be (in addition to the entities mentioned in #2949), here's at least a query that can list them:

select entity_id, lc.code, tx.string
from base_translation as tx
join base_locale as lc on locale_id = lc.id
join base_entity as ent on entity_id = ent.id
where tx.plural_form is NULL and ent.string_plural != '';

[mathjazz]

Thanks!

Could you elaborate why do we need to re-submit previously suggested and auto-rejected translations?

[mathjazz]

Please rewrite this in Django ORM. We use SQL as the last resort - in case the query is impossible or much more complex to write in Django ORM, or for performance reasons.

Something like this should work:

Translation.objects.filter(plural_form__isnull=True).exclude(entity__string_plural="").update(plural_form=0)

[eemeli]

Can do, but with the caveat that I'm pretty much out of bandwidth atm for Pontoon work given other deadlines. So if I need to rewrite this, that'll hopefully be sometime next week.

[eemeli]

Could you elaborate why do we need to re-submit previously suggested and auto-rejected translations?

Because there are only a few of these, and automating that would be more work than doing it manually.

[mathjazz]

Could you elaborate why do we need to re-submit previously suggested and auto-rejected translations?

Because there are only a few of these, and automating that would be more work than doing it manually.

I'm curious what are we actually trying to do with re-submitting these strings. Fix stati and stats?

BTW, the query you posted above finds 106 matches on prod.

[eemeli]

I'm curious what are we actually trying to do with re-submitting these strings. Fix stati and stats?

Not just that; we want to get these translations approved so that they can be used.

BTW, the query you posted above finds 106 matches on prod.

Yeah, that sounds about right. Most of those should be for the Version {0} string that don't need any action.

[mathjazz]

Thanks for clarifying.

Leaving the output here for reference:
https://gist.github.com/mathjazz/fc683bf5e5a12ba055e70c483484b049

[eemeli]

@mathjazz The migration is now Python. Based on the data dump I still had from early September, these are the messages that ought to be manually reviewed once this lands:

• https://pontoon.mozilla.org/ja/sumo/all-resources/?string=263159
• https://pontoon.mozilla.org/ko/sumo/all-resources/?string=263159
• https://pontoon.mozilla.org/th/amo/all-resources/?string=64906
• https://pontoon.mozilla.org/th/amo-frontend/all-resources/?string=195066
• https://pontoon.mozilla.org/vi/amo/all-resources/?string=278410
• https://pontoon.mozilla.org/vi/sumo/all-resources/?string=263159
• https://pontoon.mozilla.org/zh-CN/amo/all-resources/?string=278410
• https://pontoon.mozilla.org/zh-CN/sumo/all-resources/?string=263159
• https://pontoon.mozilla.org/zh-TW/amo/all-resources/?string=278410
• https://pontoon.mozilla.org/zh-TW/amo/all-resources/?string=64150
• https://pontoon.mozilla.org/zh-TW/sumo/all-resources/?string=263159

[mathjazz]

Excellent, thank you!