Centralize the editor selector definitions in the stamp editor integration tests #19350
Conversation
Puppeteer recently got updated to version 24.0.0+, so we're past version 23.9.1- where the integration test failed before and we can enable it again now that it passes in Chrome.
…ation tests In most integration tests we already use the pattern of defining the editor selector once and reusing it in the rest of the test, but it's not fully consistent everywhere yet. This commit fixes that for the stamp editor integration tests, which has multiple advantages: - it improves consistency between the various editor integration tests; - it removes duplicate function calls and aligns variable definitions; - it reduces the number of `getEditorSelector` calls and other helper function calls that contained hardcoded IDs (by updating them to take editor selectors as arguments instead of editor IDs), which helps to isolate the tests and to simplify follow-up patches.
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/2451d7548300a81/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/62e3123495e3579/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/2451d7548300a81/output.txt Total script time: 10.46 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/62e3123495e3579/output.txt Total script time: 27.82 mins
|
|
/botio-windows integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 1 Live output at: http://54.193.163.58:8877/f8e46290af459f4/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/f8e46290af459f4/output.txt Total script time: 25.61 mins
|
The commit messages contain more details about the individual changes.
Fixes a part of #19065.