This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
secureProxy is deprecated in cookies #132
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pass option through via constructor
|
Any word on getting this merged in? |
|
@vladikoff Please consider merging this PR. Without it production node apps that run behind a proxy like nginx (which is most of them), cannot make use of the secure flag. I know this library isn't being maintained anymore, but please consider merging in PRs that prevent deprecation. |
DarylPinto
added a commit
to DarylPinto/sticker-surge
that referenced
this pull request
May 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
secureProxyoption has been deprecated by thecookiemodule when it is passed as a cookie option duringcookies.set(). The module recommends passing the secureProxy option in the constructor instead.pillarjs/cookies@c7cf922
This PR implements that recommendation.