chore: Enable clippy pathbuf_init_then_push lint
#2324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And fix the warnings.
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2324 +/- ##
=======================================
Coverage 93.34% 93.34%
=======================================
Files 114 114
Lines 36906 36906
Branches 36906 36906
=======================================
Hits 34449 34449
Misses 1675 1675
Partials 782 782 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to b17233c. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to b17233c. decode 4096 bytes, mask ff: No change in performance detected. time: [11.223 µs 11.271 µs 11.324 µs]
change: [-0.3971% +0.1462% +0.6540%] (p = 0.60 > 0.05)
decode 1048576 bytes, mask ff: No change in performance detected. time: [2.8869 ms 2.8961 ms 2.9069 ms]
change: [-0.3905% +0.0766% +0.5704%] (p = 0.75 > 0.05)
decode 4096 bytes, mask 7f: No change in performance detected. time: [19.528 µs 19.572 µs 19.621 µs]
change: [-0.3031% -0.0350% +0.2316%] (p = 0.80 > 0.05)
decode 1048576 bytes, mask 7f: No change in performance detected. time: [5.0743 ms 5.0875 ms 5.1022 ms]
change: [-0.2611% +0.1075% +0.4672%] (p = 0.58 > 0.05)
decode 4096 bytes, mask 3f: No change in performance detected. time: [5.5280 µs 5.5496 µs 5.5771 µs]
change: [-0.7049% -0.1873% +0.3104%] (p = 0.49 > 0.05)
decode 1048576 bytes, mask 3f: No change in performance detected. time: [1.4142 ms 1.4197 ms 1.4266 ms]
change: [-0.3918% +0.1195% +0.7051%] (p = 0.66 > 0.05)
coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [98.555 ns 98.895 ns 99.238 ns]
change: [-0.5171% -0.0433% +0.4524%] (p = 0.86 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [116.46 ns 116.86 ns 117.30 ns]
change: [-0.9974% -0.4073% +0.0720%] (p = 0.14 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [116.29 ns 116.77 ns 117.36 ns]
change: [-1.1054% +0.0185% +0.9945%] (p = 0.97 > 0.05)
coalesce_acked_from_zero 1000+1 entries: Change within noise threshold. time: [97.092 ns 97.285 ns 97.505 ns]
change: [-2.0306% -1.0659% -0.3235%] (p = 0.01 < 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [111.34 ms 111.39 ms 111.43 ms]
change: [+0.0596% +0.1323% +0.1989%] (p = 0.00 < 0.05)
SentPackets::take_ranges: No change in performance detected. time: [5.3915 µs 5.4669 µs 5.5365 µs]
change: [-2.3600% -0.1262% +2.1678%] (p = 0.91 > 0.05)
transfer/pacing-false/varying-seeds: Change within noise threshold. time: [42.536 ms 42.612 ms 42.690 ms]
change: [-2.8193% -2.5713% -2.3155%] (p = 0.00 < 0.05)
transfer/pacing-true/varying-seeds: Change within noise threshold. time: [42.943 ms 43.016 ms 43.089 ms]
change: [-2.2270% -1.9906% -1.7549%] (p = 0.00 < 0.05)
transfer/pacing-false/same-seed: Change within noise threshold. time: [42.176 ms 42.240 ms 42.305 ms]
change: [-2.8131% -2.5931% -2.3691%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: Change within noise threshold. time: [42.583 ms 42.651 ms 42.718 ms]
change: [-2.7050% -2.4853% -2.2746%] (p = 0.00 < 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: No change in performance detected. time: [892.06 ms 899.48 ms 907.09 ms]
thrpt: [110.24 MiB/s 111.18 MiB/s 112.10 MiB/s]
change:
time: [-0.4062% +0.9134% +2.2521%] (p = 0.17 > 0.05)
thrpt: [-2.2025% -0.9051% +0.4078%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected. time: [299.24 ms 301.35 ms 303.49 ms]
thrpt: [32.951 Kelem/s 33.184 Kelem/s 33.418 Kelem/s]
change:
time: [-0.3674% +0.6206% +1.5298%] (p = 0.22 > 0.05)
thrpt: [-1.5068% -0.6167% +0.3687%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [34.346 ms 34.538 ms 34.751 ms]
thrpt: [28.776 elem/s 28.954 elem/s 29.115 elem/s]
change:
time: [-0.7760% +0.1063% +1.0149%] (p = 0.81 > 0.05)
thrpt: [-1.0047% -0.1062% +0.7821%]
1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: No change in performance detected. time: [1.6470 s 1.6636 s 1.6802 s]
thrpt: [59.515 MiB/s 60.110 MiB/s 60.716 MiB/s]
change:
time: [-0.4079% +1.1174% +2.5881%] (p = 0.14 > 0.05)
thrpt: [-2.5228% -1.1051% +0.4095%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
mxinden
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And fix the warnings.