Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(Cargo.lock): update to quinn-udp v0.5.8 #2278

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

mxinden
Copy link
Collaborator

@mxinden mxinden commented Dec 10, 2024

@larseggert
Copy link
Collaborator

At what point did you want to turn on the apple-fast feature?

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.40%. Comparing base (3e65261) to head (935068c).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2278   +/-   ##
=======================================
  Coverage   95.40%   95.40%           
=======================================
  Files         113      113           
  Lines       36722    36722           
=======================================
  Hits        35033    35033           
  Misses       1689     1689           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 10, 2024

Failed Interop Tests

QUIC Interop Runner, client vs. server, differences relative to a1b9364.

neqo-latest as client

neqo-latest as server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

@mxinden
Copy link
Collaborator Author

mxinden commented Dec 10, 2024

At what point did you want to turn on the apple-fast feature?

We need a small change in neqo-udp (see #2279). Other than that, it should simply require enabling the quinn-udp fast_apple feature.

In terms of priority, I suggest the following:

  1. Get Neqo v0.11.0 into mozilla-central. This turns out more difficult than anticipated. https://phabricator.services.mozilla.com/D230494
  2. Get network.http.http3.use_nspr_for_io false Firefox pref into Beta and release.
  3. Get network.http.http3.ecn true Firefox pref into Beta and release.
  4. Implement perf(udp): enable multi-message IO on apple #2279 and enable quinn-udp fast_apple feature.

I can start (4) while (2) and (3) are riding the trains if you like.

Thoughts @larseggert?

@mxinden
Copy link
Collaborator Author

mxinden commented Dec 11, 2024

https://bugzilla.mozilla.org/show_bug.cgi?id=1935954 landed. Marking this pull request as "Ready for review".

@mxinden mxinden marked this pull request as ready for review December 11, 2024 14:57
@larseggert larseggert added this pull request to the merge queue Dec 12, 2024
Merged via the queue into mozilla:main with commit fd42bed Dec 12, 2024
94 of 98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants