test case for triggering the crash

mozilla · Mar 11, 2024 · cad33f9 · cad33f9
1 parent baa9b52
commit cad33f9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/neqo-transport/src/connection/mod.rs b/neqo-transport/src/connection/mod.rs
@@ -1938,7 +1938,6 @@ impl Connection {
 
             let path = close.path().borrow();
             if path.is_temporary() {
-                debug_assert!(false, "Path is not permanent");
                 return Err(Error::InternalError);
             }
             let (_, mut builder) = Self::build_packet_header(

diff --git a/neqo-transport/src/connection/tests/migration.rs b/neqo-transport/src/connection/tests/migration.rs
@@ -6,6 +6,7 @@
 
 use std::{
     cell::RefCell,
+    mem,
     net::{IpAddr, Ipv6Addr, SocketAddr},
     rc::Rc,
     time::{Duration, Instant},
@@ -897,6 +898,10 @@ fn retire_prior_to_migration_failure() {
             ..
         }
     ));
+
+    // See issue #1697. We had a crash when the client had a temporary path and
+    // process_output is called.
+    mem::drop(client.process_output(now()));
 }
 
 /// The timing of when frames arrive can mean that the migration path can