Update custom dimension data object names to match Google documentation #2968
Conversation
| cd5=request_data.get("dimension5", None), | ||
| cd7=request_data.get("dimension7", "website"), |
There was a problem hiding this comment.
Note: Based on this documentation, the previous setting is the correct way?
We may need to wrap both items in a nested object:
There was a problem hiding this comment.
The library google-measurement-protocol is using the measurement protocol (universal analytics), so the documentation to use is Measurement Protocol Parameters. Yes, cd5 is custom dimension 5, I believe the change in this PR is correct.
The library is using https://ssl.google-analytics.com/collect as their base URL (see the code), but the Google docs say to use https://www.google-analytics.com/collect. I wonder if the library is out of date? It looks like a fairly thin wrapper around requests, a Python HTTP request library.
This user reports a change of user agent is needed to get to the GA server: mirumee/google-measurement-protocol#22. However, the docs imply that is only needed to set the browser, platform, and mobile capabilities.
maxxcrawford
force-pushed
the
custom-dimension-ga-fix
branch
from
7a7a20c to
1433bc4
Compare
|
Closing as this is not necessary. Having a custom field may still be helpful in the future but updating the label name is not needed. |
No description provided.