Don't use custom docker compose services for CI #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relud
force-pushed
the
relud-remove-ci-containers-2
branch
2 times, most recently
from
b394d99 to
d37e0e3
Compare
relud
force-pushed
the
relud-remove-ci-containers-2
branch
from
d37e0e3 to
f875fe0
Compare
relud
commented
Jul 25, 2024
| @@ -53,34 +49,6 @@ services: | |||
| volumes: | |||
| - .:/app | |||
There was a problem hiding this comment.
devcontainer gets to keep the volume mount because it's not used in CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by defining volume mounts in
docker-compose.override.ymlthey are used by default in the dev environment, but can be disabled for CI by settingCOMPOSE_FILE. This reduces the differences between dev and CI, which allows CI to take advantage of commands likemake setupandsystemtest/test_env.sh local.This makes
docker-compose.override.ymlno longer ignored by git, which may be undesirable. If that's not acceptable, we could use the services with volume mounts in CI, because github actions support that (unlike circleci). That would require specifying--user="$(id --user):$(id --group)"in CI fordocker compose runcommands that touch /app to avoid permissions issues (note: I also tested this solution, it works).