Don't use custom docker compose services for CI #1044
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relud
force-pushed
the
relud-remove-ci-containers
branch
9 times, most recently
from
4110162 to
ff7cd66
Compare
relud
force-pushed
the
relud-remove-ci-containers
branch
from
ff7cd66 to
2bcca26
Compare
relud
commented
Jul 25, 2024
| @@ -39,20 +39,18 @@ jobs: | |||
| run: make build | |||
| - name: Verify requirements.txt contains correct dependencies | |||
| run: | | |||
| docker compose run --rm --no-deps ci shell ./bin/run_verify_reqs.sh | |||
| docker compose run --rm --user="$(id --user):$(id --group)" --no-deps test shell ./bin/run_verify_reqs.sh | |||
There was a problem hiding this comment.
set uid/gid at runtime instead of at build time via ANTENNA_UID/ANTENNA_GID because we want to publish the image tested in CI
relud
changed the title
relud
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
circleci couldn't use volume mounts, but github actions can