Slim down slack #10
Open
Slim down slack #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for now that ungraceful but at least we error
LeoMcA
approved these changes
Oct 22, 2019
| "{}?channel={}&team={}", | ||
| slack_uri_data.direct_message_uri, sur.user_id, sur.team_id | ||
| ), | ||
| sur.user.name.clone(), |
There was a problem hiding this comment.
This returns "Leo McArdle" rather than "leo", is there no way of returning the username without getting into scope hell again?
There was a problem hiding this comment.
Not hell, but complicated. The display name would require another scope and another call to an endpoint.
There was a problem hiding this comment.
Okay, I don't think it's necessary for the moment then.
fiji-flo
force-pushed
the
slim-down-slack
branch
from
822b76b to
992a295
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.