-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace pip cache of session_latest #712
Replace pip cache of session_latest #712
Conversation
c2f1932
to
f94d65d
Compare
25684bb
to
f04fa68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@javiermtorres looks good to me. I'll run some tests locally and then approve it!
f04fa68
to
77ddc64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't test it, but other than a minor comment, looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Do you think we can try to warm up this cache in the startup process? not for this PR but as an improvement thing
Signed-off-by: javiermtorres <[email protected]>
What's changing
Replaces the
/tmp/ray/session_latest/runtime_resources/pip
with a link to/tmp/ray_pip_cache
. This location is placed in either a separate volume, or shared with the host.Refs #492 partially
How to test it
Start Lumigator with
make local-up
. The directory/tmp/ray_pip_cache
needs to exist beforehand with 777 permissions. Submit an experiment using the UI. The pip cache should be present in the host directory.Additional notes for reviewers
N/A
I already...
/docs
)