Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pip cache of session_latest #712

Merged
merged 12 commits into from
Feb 7, 2025

Conversation

javiermtorres
Copy link
Contributor

What's changing

Replaces the /tmp/ray/session_latest/runtime_resources/pip with a link to /tmp/ray_pip_cache. This location is placed in either a separate volume, or shared with the host.

Refs #492 partially

How to test it

Start Lumigator with make local-up. The directory /tmp/ray_pip_cache needs to exist beforehand with 777 permissions. Submit an experiment using the UI. The pip cache should be present in the host directory.

Additional notes for reviewers

N/A

I already...

  • Tested the changes in a working environment to ensure they work as expected
  • Added some tests for any new functionality
  • Updated the documentation (both comments in code and product documentation under /docs)
  • Checked if a (backend) DB migration step was required and included it if required
    • No DB changes

@github-actions github-actions bot added the gha GitHub actions related label Jan 22, 2025
docker-compose.yaml Show resolved Hide resolved
docker-compose.yaml Outdated Show resolved Hide resolved
@javiermtorres javiermtorres force-pushed the javiermtorres/issue-492-runtime-resources branch from c2f1932 to f94d65d Compare January 29, 2025 15:43
@javiermtorres javiermtorres marked this pull request as ready for review January 29, 2025 15:44
@javiermtorres javiermtorres force-pushed the javiermtorres/issue-492-runtime-resources branch 2 times, most recently from 25684bb to f04fa68 Compare January 30, 2025 08:14
Copy link
Contributor

@dpoulopoulos dpoulopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@javiermtorres looks good to me. I'll run some tests locally and then approve it!

@javiermtorres javiermtorres force-pushed the javiermtorres/issue-492-runtime-resources branch from f04fa68 to 77ddc64 Compare January 31, 2025 11:39
Copy link
Contributor

@njbrake njbrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test it, but other than a minor comment, looks good to me.

docker-compose.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@agpituk agpituk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Do you think we can try to warm up this cache in the startup process? not for this PR but as an improvement thing

@javiermtorres javiermtorres merged commit b64c7c2 into main Feb 7, 2025
15 checks passed
@javiermtorres javiermtorres deleted the javiermtorres/issue-492-runtime-resources branch February 7, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gha GitHub actions related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants