-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement job_result_download for experiment service #632
Conversation
bbab0b5
to
9283c23
Compare
a725415
to
3ee4aac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Some comments but I'm pre-ok with your responses :)
589e764
to
7d92dd7
Compare
3e0f901
to
31d95f1
Compare
@aittalam - ready for a re-review, I've incorporated all the changes since the last time this was reviewed and noted a place we might want to be careful |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
ee93b2b
to
21da5d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TY Vicki! I think this is ready to merge after syncing with main.
Many thanks for addressing my comments 🙏
Co-authored-by: Davide Eynard <[email protected]> Signed-off-by: Vicki Boykis <[email protected]>
Co-authored-by: Davide Eynard <[email protected]> Signed-off-by: Vicki Boykis <[email protected]>
4a49e79
to
670387b
Compare
What's changing
We currently download results per job. We'd like to implement all data results downloaded per experiment.
In order to make these changes, we need to change the jobs, experiments service, and related API calls.
Provide a clear and concise description of the content changes you're proposing. List all the changes you are making to the content.
See #572
How to test it
Steps to test the changes:
You should get URLs for two files:
Additional notes for reviewers
I already...
/docs
)