-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update moveit_servo tutorial to release 1.3.x of UR5 #753
base: master
Are you sure you want to change the base?
Conversation
I would suggest @fmauch and/or @RobertWilbrandt actually. They've taken over / are the main maintainers now. |
If the UR maintainers can't add support for a Joint Trajectory Controller or a Joint Group Position Controller, then I think we should just merge #750. I wish I had time to update the tutorial properly but I don't. |
Maybe give them some time to respond? |
1bc400e
to
ed48e29
Compare
The falling robot is actually on our priority ToDo list at the moment. @RobertWilbrandt can say more about this. If it helps I would not see a downside in adding the |
@fmauch: Was this implemented meanwhile? |
I'll check and come back to you tomorrow. |
I've made a PR with the relevant changes: ros-industrial/universal_robot#685 With this I can for example start
to get a fully position-controlled robot. |
This attempts to fix #750 in a cleaner way (i.e. actually fix the tutorial).
The UR5 config files have considerably changed since the
moveit_servo
tutorial was written.This PR addresses all renamings of files, links, and controllers.
However, it still doesn't work, because the UR repo removed support for the
joint_group_position_controller
in Gazebo. There is only an effort controller:joint_group_eff_controller
. While interface-wise that seems to work (moveit_servo
doesn't complain), it eventually fails with:Maybe, this is due to the fact that switching controllers from
eff_joint_traj_controller
tojoint_group_eff_controller
made the robot fall back to the floor. The robot doesn't maintain its pose!@AndyZe, @gavanderhoorn, please have a look / comment.