Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Isaac Panda tutorial to be compatible with Isaac Sim 4.5 and below #1009

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ayushgnv
Copy link

Description

With the upcoming release of Isaac Sim 4.5, this PR introduces updates to ensure the Isaac Panda tutorial remains current while maintaining backward compatibility with older versions of Isaac Sim.

Summary of Changes:

  • Updated logic to detect Isaac Sim 4.5 in its new installation path.
  • Adjusted import statements to accommodate renamed extensions and python modules introduced in Isaac Sim 4.5.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

@henningkayser henningkayser self-requested a review January 24, 2025 12:35
Copy link
Member

@henningkayser henningkayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! The changes look good to me overall. Unfortunately, I can't test this myself due to unmet hardware requirements. Approving anyway, since backwards compatibility is provided.

@@ -293,12 +499,14 @@
target_prim_paths=[CAMERA_PRIM_PATH],
)

simulation_app.update()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this duplicate update call intentional? If yes, a comment would be nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants