Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allowed_start_tolerance_joints parameter (Port moveit#3287) (backport #3309) #3328

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Feb 6, 2025

Description

Allow to specify a per joint allowed start tolerance for the TrajectoryExecutionManager. Port from moveit/moveit#3287 with some changes to be able to dynamically update its values at runtime.

Example of usage

In moveit_controllers.yaml:

trajectory_execution:
  allowed_execution_duration_scaling: 1.2
  allowed_goal_duration_margin: 0.5
  allowed_start_tolerance: 0.01
  allowed_start_tolerance_joints: {panda_joint3: 0.02, panda_joint5: 0.03, panda_finger_joint1: 0.005}

Joints that are not declared in allowed_start_tolerance_joints will use allowed_start_tolerance as the default.

Some remarks

  • I would personally have named this parameter "allowed_start_tolerance_joints" to be next to "allowed_start_tolerance" when sorted alphabetically. However, to maintain continuity with the original PR, I kept it as is.
  • I left the tests as they are because test_execution_manager.cpp is not used at the moment, right?
  • Why skip negative tolerances? I think, rather than defaulting to allowed_start_tolerance, it would be more intuitive to use the absolute value in that case.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

This is an automatic backport of pull request #3309 done by [Mergify](https://mergify.com).

* Add joints_allowed_start_tolerance parameter (moveit/moveit#3287)
... for joint-specific start tolerances for TrajectoryExecutionManager

Co-authored-by: Robert Haschke <[email protected]>

* Port to moveit2

* Allow joints_allowed_start_tolerance to be updated dynamically

* Apply formatting

* Rename joints_allowed_start_tolerance to allowed_start_tolerance_joints

---------

Co-authored-by: Hugal31 <[email protected]>
Co-authored-by: Robert Haschke <[email protected]>
(cherry picked from commit 9922704)
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 19.60784% with 41 lines in your changes missing coverage. Please review.

Project coverage is 44.14%. Comparing base (ddfab7d) to head (9b298ef).
Report is 1 commits behind head on jazzy.

Files with missing lines Patch % Lines
...ution_manager/src/trajectory_execution_manager.cpp 19.61% 41 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##            jazzy    #3328      +/-   ##
==========================================
- Coverage   44.15%   44.14%   -0.00%     
==========================================
  Files         700      700              
  Lines       61683    61727      +44     
  Branches     7477     7487      +10     
==========================================
+ Hits        27229    27246      +17     
- Misses      34286    34313      +27     
  Partials      168      168              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sea-bass sea-bass merged commit 6c5e6ec into jazzy Feb 6, 2025
7 checks passed
@sea-bass sea-bass deleted the mergify/bp/jazzy/pr-3309 branch February 6, 2025 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants