Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load robot_description from other namespace (backport #3269) #3324

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Feb 6, 2025

Description

Add namespace to the topic to read robot_description

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • [ / ] Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • [ / ] Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

This is an automatic backport of pull request #3269 done by [Mergify](https://mergify.com).

* load robot_description from other namespace

* change temp_node's namespace

---------

Co-authored-by: Sebastian Jahr <[email protected]>
(cherry picked from commit af6d762)

# Conflicts:
#	moveit_ros/planning/rdf_loader/src/synchronized_string_parameter.cpp
@mergify mergify bot added the conflicts label Feb 6, 2025
Copy link
Author

mergify bot commented Feb 6, 2025

Cherry-pick of af6d762 has failed:

On branch mergify/bp/humble/pr-3269
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit af6d762ec.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   moveit_ros/planning/rdf_loader/src/synchronized_string_parameter.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@sea-bass sea-bass removed the conflicts label Feb 6, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 51.41%. Comparing base (9aefcb8) to head (b612d7e).
Report is 1 commits behind head on humble.

Files with missing lines Patch % Lines
...g/rdf_loader/src/synchronized_string_parameter.cpp 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #3324      +/-   ##
==========================================
- Coverage   51.42%   51.41%   -0.00%     
==========================================
  Files         382      382              
  Lines       31892    31892              
==========================================
- Hits        16397    16394       -3     
- Misses      15495    15498       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sea-bass sea-bass merged commit 33cf8a4 into humble Feb 6, 2025
7 checks passed
@sea-bass sea-bass deleted the mergify/bp/humble/pr-3269 branch February 6, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants