Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docstring for Servo smoothHalt function (backport #3298) #3308

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Feb 4, 2025

Description

I was debugging something related to #3251 and noticed that the docstring for Servo::smoothHalt() was slightly out of date in explaining its return type.

Super small change.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

This is an automatic backport of pull request #3298 done by [Mergify](https://mergify.com).

@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.12%. Comparing base (f846188) to head (ef9734f).
Report is 2 commits behind head on jazzy.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##            jazzy    #3308      +/-   ##
==========================================
- Coverage   44.13%   44.12%   -0.00%     
==========================================
  Files         700      700              
  Lines       61669    61668       -1     
  Branches     7473     7473              
==========================================
- Hits        27209    27205       -4     
- Misses      34292    34296       +4     
+ Partials      168      167       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sea-bass sea-bass merged commit 969bd40 into jazzy Feb 4, 2025
7 checks passed
@sea-bass sea-bass deleted the mergify/bp/jazzy/pr-3298 branch February 4, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants