-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Ros2ControlManager chained controller logic #3301
Conversation
Signed-off-by: Paul Gesel <[email protected]>
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3301 +/- ##
==========================================
- Coverage 45.59% 45.57% -0.02%
==========================================
Files 716 716
Lines 62385 62387 +2
Branches 7546 7544 -2
==========================================
- Hits 28441 28429 -12
- Misses 33778 33791 +13
- Partials 166 167 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Signed-off-by: Paul Gesel <[email protected]> (cherry picked from commit cf1d3e0)
Signed-off-by: Paul Gesel <[email protected]> (cherry picked from commit cf1d3e0)
Signed-off-by: Paul Gesel <[email protected]> (cherry picked from commit cf1d3e0) Co-authored-by: Paul Gesel <[email protected]>
Signed-off-by: Paul Gesel <[email protected]> (cherry picked from commit cf1d3e0) Co-authored-by: Paul Gesel <[email protected]>
Description
It looks like this PR might have broken the chained controller management logic.
Previously,
claimed_interfaces
were being used to determine which joints each controller was associated with, but nowrequired_command_interfaces
is used. That seems reasonable, but it was not updated everywhere. Specifically, there is some logic to handle ros2_control's chained controllers that was not updated. This PR fixes that issue.